search

CensoredUsername / unrpyc

A ren'py script decompiler
Other
864 stars 157 forks source link

"rpymc"->"rpym" Ren'Py script module support #67

Closed Uzume closed 5 years ago

Uzume commented 6 years ago

Does un.rpyc intentionally not support decompiling Ren'Py script modules loaded with renpy.load_module (not to be confused with renpy.loader.load_module)? Information on this can be found in its documentation and the older wiki.

I ask this, because I could not find this support in un.rpyc (although I could not see why unrpyc.decompiler would not support such) and according a quick blame search in Ren'Py source, it has supported such for upwards of 10-12 years (I did not attempt to dig deeper; the codebase has moved around and it is quite possible such modules were supported even earlier in Ren'Py). According to the older wiki this feature was introduced in 6.6.0, released February 10, 2008 (making it a little less than ten years old).

It should be noted that renpy.script treats rpy/rpyc scripts and rpym/rpymc script modules very similarly and more specifically renpy.script.load_file handles rpy/rpym and rpyc/rpymc in exactly the same way.

CensoredUsername commented 6 years ago

I honestly forgot script modules were actually a thing, and nobody has ever requested support for it (probably because almost nobody uses them except for the engine itself).

I'll look into it.

CensoredUsername commented 6 years ago

I've added support in 381cfa5, will merge it after some testing.

Uzume commented 6 years ago

There is a typo in the above patch; see the comment on the commit.

CensoredUsername commented 6 years ago

The typo has been fixed on dev.

Uzume commented 6 years ago

I am assuming you are referring to ddc961c. That seems to have been fixed on innocent_witches branch but not on dev branch.

CensoredUsername commented 6 years ago

Whoops, worked on both at the same time and forgot to also push my local dev branch. It should be correct now.

CensoredUsername commented 5 years ago

Since no further replies came in I'll assume this is fixed.