search

CensoredUsername / unrpyc

A ren'py script decompiler
Other
837 stars 149 forks source link

Choice boxes doesn't appear after script decompilation #89

Closed TakaiSaisei closed 4 years ago

TakaiSaisei commented 4 years ago

Seems that decompiler generating incorrect code - instead of in-game choice boxes I'm getting just exceptions. There are 2 tracebacks (I think they're almost the same) - 1st from welcome screen asking you to select a language, 2nd from the gameplay itself. traceback1.txt traceback2.txt

If I understood correctly. the problem located in screens.rpy, so there are original screens.rpyc also. https://drive.google.com/open?id=1YHwriKbwcaDGHi9sKkEPAun-GX37zBCF

Game: The Expression Amrilato (RenPy 7.3.2.320)

CensoredUsername commented 4 years ago

Could you also send me game/splash.rpy? The issue is with arguments being passed to the choice screen, which seem to not be there.

TakaiSaisei commented 4 years ago

Ugh, sorry, I'd checked it more carefully, decompilation of screens.rpyc have nothing with it. I get exception on welcome screen after decompilation of splash.rpyc, exception in 1st chapter after decompilation of am001a.rpyc, in 2nd chapter after am002a.rpyc and so on.

.rpyc - original, .rpy - decompiled with latest version of unrpyc

splash.rpyc splash.rpy am001a.rpyc am001a.rpy

In am001a.rpy choice screen appears at 713 string.

CensoredUsername commented 4 years ago

Looks like the issue is that we don't support menu arguments / menu item arguments yet. Should be an easy fix.

CensoredUsername commented 4 years ago

There's a fix available on the dev branch, could you test it and confirm everything works?

TakaiSaisei commented 4 years ago

Yep, it's okay now, thank you.

CensoredUsername commented 4 years ago

Just a headsup, the dev release didn't support menu arguments themselves yet, which in the new release are also reported. Your rpyc file also used those.