search

CensoredUsername / unrpyc

A ren'py script decompiler
Other
874 stars 157 forks source link

atl.rawchild in Hate Plus #9

Closed hmngh closed 11 years ago

hmngh commented 11 years ago

While decompiling script.dlc2.rpyc in Hate Plus some of the image definitions are decompiled as TODO atl.RawChild Will support for atl children be implemented in the near future?

yuriks commented 11 years ago

(Huh, what happened to the other comments in this thread?)

I'm not working on this script anymore. If anyone wants to fix this I'll gladly add you to the project or accept a pull request.

weetabix-su commented 11 years ago

Is this the one for the lolbot decompile script? Yeah, it's supposed to do that for both Analogue and Hate Plus. Try removing the Korean translated scripts first and see if it works.

On Sep 5, 2013, at 2:55, hmngh notifications@github.com wrote:

I have already tried it, the script throws either

UnicodeDecodeError: 'ascii' codec can't decode byte 0xeb in position
7: ordinal not in range(128)

or

NameError: global name '_m1_decompile__LB_renpy_error_on_python_fail'
is not defined

\ Reply to this email directly or view it on GitHub.

weetabix-su commented 11 years ago

Sorry mate, removed it myself. Thought you're still working on this and considered deleting it.

On Sep 5, 2013, at 5:27, Yuri Kunde Schlesner notifications@github.com wrote:

(Huh, what happened to the other comments in this thread?)

I'm not working on this script anymore. If anyone wants to fix this I'll gladly add you to the project or accept a pull request.

\ Reply to this email directly or view it on GitHub.

hmngh commented 11 years ago

After removing the translation I was able to decompile game files using lolbot's script, but still getting

TODO atl <renpy.atl.RawChild object at 0xa98706c>

Both using decompilation from source code and bytecode. I assume this might be related to the fact, that ATL statements are not fully supported by the script for python 2.6, which is used by Hate Plus.

2013/9/5 Mikko Luis Saavedra notifications@github.com

Is this the one for the lolbot decompile script? Yeah, it's supposed to do that for both Analogue and Hate Plus. Try removing the Unicode-translated scripts first and see if it works.

CensoredUsername commented 11 years ago

I'll take a look and see what I can figure out, but since I don't have an example of where this statement is used it is rather hard to figure out. The issue is simply that no code exists yet to handle atl.RawChild in decompiler.print_atl(). If anyone could provide a sample which triggers this issue it'd be appreciated.

weetabix-su commented 11 years ago

You could open up renpy/atl.py in the game's base folder.

On Sep 9, 2013, at 3:35, CensoredUsername notifications@github.com wrote:

I'll take a look and see what I can figure out, but since I don't have an example of where this statement is used it is rather hard to figure out. The issue is simply that no code exists yet to handle atl.RawChild in decompiler.print_atl(). If anyone could provide a sample which triggers this issue it'd be appreciated.

\ Reply to this email directly or view it on GitHub.

CensoredUsername commented 11 years ago

Yeah that's what I was doing, just testing it now, fix is almost ready.

CensoredUsername commented 11 years ago

dc6f5dacf3279468708b661da8791f79f8e94597 Should fix this. Would any of you mind to test if this completely fixes your issues too?

hmngh commented 11 years ago

Just change the write statement to write child instead of block and it works perfectly.

CensoredUsername commented 11 years ago

To be clear by the way, this is not for the lolbot decompile script.

Is this the one for the lolbot decompile script? Yeah, it's supposed to do that for both Analogue and Hate Plus. > Try removing the Korean translated scripts first and see if it works.