search

CentEAP / eap-build

Build scripts for EAP 6 or 7
122 stars 62 forks source link

Adding 7.2.8, 7.2.9, and 7.3.10 #175

Closed georgesberscheid closed 2 years ago

georgesberscheid commented 2 years ago

Updated maven repo from https://maven.repository.redhat.com/earlyaccess to https://maven.repository.redhat.com/ga Inserted dependencies for org.jboss.msc and java.desktop to module domain-http-interface

Builds and starts up properly, my application also runs correctly, but I have to admit that I'm probably not aware of the full impact of those changes.

Thanks @cher1705 for the suggestions.

cher1705 commented 2 years ago

@jarkkosonninen does it work now?

cher1705 commented 2 years ago

@hasalex how about you?

hasalex commented 2 years ago

@georgesberscheid Thanks for the PR. Could you open an issue that explains the problems you faced ? It would be even better with code examples, so that we can build our test application.

georgesberscheid commented 2 years ago

@hasalex There is no problem in the current master branch, but there was a problem during startup in a previous version of this PR:

Failed to define class org.jboss.as.domain.http.server.ConsoleAvailabilityService in Module "org.jboss.as.domain-http-interface" version 6.0.30.Final-redhat-00001 from local module loader @79698539 (finder: local module finder @73f792cf (roots: /Users/jso/LT/jboss-eap-7.2.9/modules,/Users/jso/LT/jboss-eap-7.2.9/modules/system/layers/base)): java.lang.NoClassDefFoundError: Failed to link org/jboss/as/domain/http/server/ConsoleAvailabilityService (Module "org.jboss.as.domain-http-interface" version 6.0.30.Final-redhat-00001 from local module loader @79698539 (finder: local module finder @73f792cf

The current version of the PR addresses this problem here: https://github.com/hasalex/eap-build/pull/175/files#diff-96b82b62b33aafc9226dbc9a02f95c2246918f27c55d23daac06a4b59bc7fcbaR137 as recommended by @cher1705

All added patch versions 7.2.8, 7.2.9, and 7.3.10 now build and run properly.

hasalex commented 2 years ago

@georgesberscheid OK, and what does the change from earlyaccess to ga fix ?

georgesberscheid commented 2 years ago

Alright, so I thought that this maven repo change was only required to build 7.2.8 / 7.2.9, but from my tests it appears that we cannot build previous versions either without changing the maven repo URL. It seems like Redhat changed the repo URLs as described here: https://access.redhat.com/maven-repository

Available repos are now:

cher1705 commented 2 years ago

Alright, so I thought that this maven repo change was only required to build 7.2.8 / 7.2.9, but from my tests it appears that we cannot build previous versions either without changing the maven repo URL. It seems like Redhat changed the repo URLs as described here: https://access.redhat.com/maven-repository

Available repos are now:

* General availability repository: https://maven.repository.redhat.com/ga/

* Early-access repository: https://maven.repository.redhat.com/earlyaccess/all/

Thanks, did you tried to build some dists by changing the repo to use Early-access repository: https://maven.repository.redhat.com/earlyaccess/all/

For me, it's working, if I build eg 7.2.4