CentEAP / eap-build

Build scripts for EAP 6 or 7
122 stars 62 forks source link

7.4.7 #180

Closed fcorneli closed 1 year ago

fcorneli commented 1 year ago

Tried to build EAP 7.4.7, but stumbled upon a compilation error:

[ERROR] Failed to execute goal org.wildfly.build:wildfly-server-provisioning-maven-plugin:1.2.12.Final:build (server-provisioning) on project wildfly-dist-legacy: 
Execution server-provisioning of goal org.wildfly.build:wildfly-server-provisioning-maven-plugin:1.2.12.Final:build failed: 
java.lang.RuntimeException: java.lang.IllegalStateException: 
Can't find included supplement 'no-multicast' -> [Help 1]

Somehow related to the following change:

diff -u jboss-eap-7.4.6-src/clustering/jgroups/extension/src/main/resources/subsystem-templates/jgroups.xml \
jboss-eap-7.4.7-src/clustering/jgroups/extension/src/main/resources/subsystem-templates/jgroups.xml
hasalex commented 1 year ago

Tricky issue! I don't think that it come from the jgroups.xml file, because when I replace it with the 7.4.6 version, the same error occurs. I would say that it comes from a dependency. But no idea which one. Investigation in process...

fcorneli commented 1 year ago

I would say that it comes from a dependency. But no idea which one.

This sound like fun fun fun...

henschi commented 1 year ago

The dependency is wildfly-clustering-jgroups-extension-7.4.7.GA-redhat-00003.jar (dest in jboss: modules/system/layers/base/org/jboss/as/clustering/jgroups/main) and with will be downloaded from redhat and not build from jboss source. The failing build step used this downloaded dependency. And in this dep is the changed jgroups.xml file.

My current "stupid" solution. Build with standard 7.4.7 adaption. This build will be crash, but the dependency wildfly-clustering-jgroups-extension-7.4.7.GA-redhat-00003.jar was downloaded. Because we don't use jgroups with ec2, azure and gossip, I changed the downloaded dependency in my maven m2 directory and remove the "no-multicast" usage in supplement include attribute. The next build will be used my change dependency and the build is ok.

hasalex commented 1 year ago

Great job @henschi ! It seems to be difficult to patch the dependency on the fly in a safe way. The other solution could be to use 7.4.6 version.

cher1705 commented 1 year ago

is it possible to exclude ec2,s3,azure,gossip somehow? and @henschi how did you do this exactly? didn't get it.

hasalex commented 1 year ago

Here is my proposal : https://github.com/CentEAP/eap-build/pull/181 Try it and tell what you think about it.

fcorneli commented 1 year ago

@hasalex Works just fine. Thanks!

cher1705 commented 1 year ago

Here is my proposal : #181 Try it and tell what you think about it.

Stupid question... We are focusing us on the dist-legacy part... I'm honestly not familiar with galleon part..but this was afaik ee-dist, right? what if I build ee-dist instead of dist-legacy? because, I was able to build ee-dist...but I have no idea, if I can use it...how about you?

here are my quick changes, just for building 7.4.7 with ee-dist...

jboss-eap-7.properties 7.4.7.xpath.delete.eap=ee-dist/pom.xml,//:dependency[:artifactId='wildfly-testsuite-shared']

functions-7.sh -> build_eap mv ee-dist dist maven_build dist

hasalex commented 1 year ago

Stupid question...

This stupid question is brilliant!

If it works, it's a good idea to switch away from legacy. I've tested on other 7.4 updates, and it works except for 7.4.3 and 7.4.1.

I propose that @cher1705 you create an other ticket for this specific change.

cher1705 commented 1 year ago

Stupid question...

This stupid question is brilliant!

If it works, it's a good idea to switch away from legacy. I've tested on other 7.4 updates, and it works except for 7.4.3 and 7.4.1.

I propose that @cher1705 you create an other ticket for this specific change.

I will do so...

I don't know, how you build your eap but I was able to build all 7.4.x by the use of ee-dist with following settings... 7.4.x.xpath.delete.eap=ee-dist/pom.xml,//:dependency[:artifactId='wildfly-testsuite-shared']

that's why I suggest, to add just an exception for 7.3.x