CentML / centml-python-client

Apache License 2.0
1 stars 0 forks source link

Better exception catching #69

Closed destefy closed 4 months ago

destefy commented 4 months ago

Previously, if the call to submit for compilation or to check the model status would fail, then the compilation thread would crash. I added try catch blocks to catch this while still logging the raised errors.

I also added a unit test to cover the case where the call to compilation or status fails.

I also realized that the try catch block around the child thread creation call wasn't actually catching exceptions that happen in the thread, just any exceptions that happen when you create the thread. Since this means that an exception in the child thread won't case the main inference thread to crash, I don't know if we actually need to catch it, but I fixed this to catch exceptions as expected