search

CentOS-PaaS-SIG / ci-pipeline

There are many projects that are concentrated on CI for Atomic Openshift. This is focused on complete CI testing of all Atomic and Base Runtime components for a new Atomic deliverable that comes from Fedora sources.
GNU General Public License v3.0
23 stars 35 forks source link

Fedora upstream will support PRs on tests namespace #758

Closed bgoncalv closed 5 years ago

bgoncalv commented 5 years ago

For Fedora upstream pipeline to support PR on tests namespace these changes are required

Some trailing whitespaces got removed as well.

bgoncalv commented 5 years ago

[upstream-test]

bgoncalv commented 5 years ago

@johnbieren does this make sense? :)

johnbieren commented 5 years ago

So if namespace = tests, the dir where the tests live is just different? That makes sense to me. Won't triggers have to change to listen to the additional namespace as well?

bgoncalv commented 5 years ago

So if namespace = tests, the dir where the tests live is just different? That makes sense to me.

Yes, the idea if tests.yml will be defined directly on root of the repo, like https://src.fedoraproject.org/tests/shell/tree/master there there would be tests.yml there. @psss is it correct?

Won't triggers have to change to listen to the additional namespace as well?

Yes, on upstream-fedora-pipeline we will need to include new trigger for it, also some other changes to the main Jenkinsfile to handle it, and I believe some changes related to the message sent to fedmsg. But I haven't had time to check it into details yet.

psss commented 5 years ago

Yes, the idea if tests.yml will be defined directly on root of the repo, like https://src.fedoraproject.org/tests/shell/tree/master there there would be tests.yml there. @psss is it correct?

Yes, exactly. The tests.yml file should be in the root of the test namespace directory so that tests then can be referenced from it directly.

bgoncalv commented 5 years ago

[upstream-merge] [merge]

adl-bot commented 5 years ago

The following image promotions have taken place:

bgoncalv commented 5 years ago

@johnbieren fyi, singlehost-test image didn't get promoted automatically, we needed to tag it manually.

johnbieren commented 5 years ago

@bgoncalv yeah, the upstream-merge and merge trigger two separate merge jobs. One promotes cloud-image-compose, the other promotes singlehost-test (among others). No good answer is in place for PRs that affect both. I know you commented both merge commands (wisely), but it seems that whichever merge job goes first actually merges the PR and continues and the other does nothing I guess