search

CentOS-PaaS-SIG / ci-pipeline

There are many projects that are concentrated on CI for Atomic Openshift. This is focused on complete CI testing of all Atomic and Base Runtime components for a new Atomic deliverable that comes from Fedora sources.
GNU General Public License v3.0
23 stars 35 forks source link

use --list-tags from ansible to check if specific tag is set #766

Closed bgoncalv closed 5 years ago

bgoncalv commented 5 years ago

Use of ansible to check for tags should make easier to check for tags, form example if it is set like:

tags: [classic, container, atomic]

bgoncalv commented 5 years ago

@johnbieren could you check this? It seems the tests didn't run well....

thrix commented 5 years ago

LGTM, staging passed

bgoncalv commented 5 years ago

Hmm, good point. Although, I'm not sure where we would use the function that uses grep as it might not return the proper result.

bgoncalv commented 5 years ago

@johnbieren I think ansible is already installed on slave, isn't it? https://github.com/CentOS-PaaS-SIG/ci-pipeline/blob/master/config/s2i/jenkins/slave/Dockerfile https://github.com/CentOS-PaaS-SIG/upstream-fedora-pipeline/blob/master/config/s2i/jenkins/slave/Dockerfile

johnbieren commented 5 years ago

@bgoncalv Sorry, I wasn't suggesting that I am aware of anywhere currently that uses the function and is run from a slave without ansible. Just pointing out the technical consequence of the change. If using grep is not truly correct and it is only truly correct with ansible, I am fine with this change and having the function be dependent on ansible being present

bgoncalv commented 5 years ago

[merge]