search

CentOS-PaaS-SIG / ci-pipeline

There are many projects that are concentrated on CI for Atomic Openshift. This is focused on complete CI testing of all Atomic and Base Runtime components for a new Atomic deliverable that comes from Fedora sources.
GNU General Public License v3.0
23 stars 35 forks source link

use ansible + str to check of tag on playbooks #773

Closed bgoncalv closed 5 years ago

bgoncalv commented 5 years ago

If standard-test-roles is available use it to check for tag in the playbooks

johnbieren commented 5 years ago

@bgoncalv I'd recommend you add the path for the slave directory around here https://github.com/CentOS-PaaS-SIG/ci-pipeline/blob/master/upstream-fedora-pipeline/AllPackagePipelineStageTrigger#L104 Because of the state of the f27 atomic stage pipeline, it doesn't get far enough to try checkTests and the upstream-fedora-pipeline is dropping this change as not relevant because of ^^

bgoncalv commented 5 years ago

thanks, I've updated it

johnbieren commented 5 years ago

https://jenkins-continuous-infra.apps.ci.centos.org/job/test-for-bruno/1/console

19:10:16 [test-for-bruno] Running shell script
19:10:17 + grep -e 'TASK TAGS: \[.*\<classic\>.*\]'
19:10:17 + ansible-playbook --list-tags standard-test-roles/tests/tests.yml
19:10:17  [WARNING]: provided hosts list is empty, only localhost is available. Note
19:10:17 that the implicit localhost does not match 'all'
19:10:18       TASK TAGS: [classic]
[Pipeline] echo
19:10:18 Starting package-tests

Is this what is expected?

bgoncalv commented 5 years ago

https://jenkins-continuous-infra.apps.ci.centos.org/job/test-for-bruno/1/console

19:10:16 [test-for-bruno] Running shell script
19:10:17 + grep -e 'TASK TAGS: \[.*\<classic\>.*\]'
19:10:17 + ansible-playbook --list-tags standard-test-roles/tests/tests.yml
19:10:17  [WARNING]: provided hosts list is empty, only localhost is available. Note
19:10:17 that the implicit localhost does not match 'all'
19:10:18       TASK TAGS: [classic]
[Pipeline] echo
19:10:18 Starting package-tests

Is this what is expected?

Yes, it is some warning from ansible. If you think this can be confusing I can redirect the output...

johnbieren commented 5 years ago

Tbh, I interact with these pipelines very little nowadays (just for messaging and to help you guys in the rare times you need it!) so whatever output you think is best is fine by me.

If that stage job looks good I am fine with you merging this. I have an idea for how to have the shared lib changes that affect the upstream-fedora-pipeline be tested properly... on my todo list to try out

thrix commented 5 years ago

@bgoncalv I believe we can live with another warning

bgoncalv commented 5 years ago

[merge]

adl-bot commented 5 years ago

The following image promotions have taken place: