search

CentOS-PaaS-SIG / contra-env-infra

Repository to store core infrastructure s2i templates and dockerfiles to support DevOps and CI/CD workflows
GNU General Public License v3.0
3 stars 14 forks source link

Is OVERRIDE_PV_CONFIG_WITH_IMAGE_CONFIG intended? #19

Open johnbieren opened 5 years ago

johnbieren commented 5 years ago

In the Jenkins master s2i... https://github.com/CentOS-PaaS-SIG/contra-env-infra/blob/master/jenkins/master/s2i/jenkins-persistent-template.yml#L162 Just wondering if this was intended or just some copy paste code, as it causes all previous data in /var/lib/jenkins to be lost whenever the master restarts. If there is not an argument for it, I'd say we can probably remove it, but if there is a reason to have it, that is fine.

joejstuart commented 5 years ago

Good question. Having persistent in the filename makes it confusing at the least. I'll take a look at it.