search

CentOS-PaaS-SIG / linchpin

ansible based multicloud orchestrator
http://linchpin.readthedocs.io
GNU General Public License v3.0
114 stars 70 forks source link

Possible Improvement Scope: Leftover Installation in the Ansible test scripts #1768

Open Talismanic opened 3 years ago

Talismanic commented 3 years ago

Greetings, I am an engineer who is interested in infrastructure as code testing. Currently, I am looking for testing anti-patterns in iac test scripts. I noticed that for testing purpose we sometimes install different packages, but do not clean those after the testing is completed. This may lead to problem in sub-sequent tests if the same environment is used in multiple testing or keep some unwanted packages installed in the environment. For example, in this file, we can see that task is installing python3.4 and some pre-requisite dependencies. After the test, it is not cleaning any of them. Though in this case, it should not cause any problem as python is harmless. But in case someone uses same environment for testing with some python scripts compatible with 2.7, they can face some issue theoretically.

So, I have the following queries: Do you principally agree that if any package is installed for testing purpose, we should remove the package?

Do you want to add a step to remove the packages?

Any feedback is appreciated.

JunqiZhang0 commented 3 years ago

Hi @Talismanic , thank you for giving your opinion to linchpin! Linchpin is now under maintenance mode, it only supports business critical features/bug fixes, as this doesn't cause any problem, we will just leave it as is. You can always submit a PR and we will review it. Thanks!