CentOS / CentOS-Dockerfiles

Dockerfiles for various common implementations
GNU General Public License v2.0
1.86k stars 1.25k forks source link

Fix dockerfile user from 997 to nginx #178

Closed petrkotas closed 6 years ago

petrkotas commented 6 years ago

This PR fixes the UID mismatch inside of the Dockerfile.

The UID 997 did not match the real nginx user inside of the container. The nginx UID is 999.

Fixed by switching from UID to username.

Signed-off-by: Petr Kotas petr.kotas@gmail.com


This change is Reviewable

mykaul commented 6 years ago

Thanks - looks good to me and works for me.

petrkotas commented 6 years ago

@mohammedzee1000 would you mind taking look at this PR and if you agree can you merge? Thank you.

petrkotas commented 6 years ago

@jperrin Hi Jim, sorry for bothering you. Would you mind looking at this PR and see whether you are OK with it?

jperrin commented 6 years ago

Seems legit, but I don't have an openshift setup where I could test this. I'll merge it in, and if it breaks we can revert.