CentOS / centos-bootc

Create and maintain base bootable container images from Fedora ELN and CentOS Stream packages
https://centos.github.io/centos-bootc
Other
43 stars 28 forks source link

Consider disabling `dnf-makecache.timer` #481

Open jlebon opened 2 months ago

jlebon commented 2 months ago

See https://github.com/openshift/os/pull/1476#issuecomment-2050027990.

$ podman run -ti --rm quay.io/centos-bootc/centos-bootc:stream9 systemctl is-enabled dnf-makecache.timer
enabled

But cc @dcantrell for his thoughts on the suggestion there.

travier commented 2 months ago

Should we make this unit condition on !/run/ostree-booted?

jlebon commented 2 months ago

Should we make this unit condition on !/run/ostree-booted?

It already is. The problem is more that it pulls in network-online.target, which is not recommended. We have a test in FCOS/RHCOS to make sure it doesn't inadvertently get activated with the default units.

cgwalters commented 2 months ago

I think this is something to fix upstream in dnf, honestly. It should gracefully wait for network availability and not error out.

(Incidentally we have a related problem in rpm-ostree-countme.timer I've noticed the service failing, but the service shouldn't fail if networking isn't working)