CentOS / container-pipeline-service

Code, infrastructure and deployment backend for the CentOS Container Pipeline backing up build system for registry.centos.org
https://registry.centos.org
GNU General Public License v3.0
49 stars 27 forks source link

Fixing weekly scan to run in proper controlled manner. #615

Closed mohammedzee1000 closed 6 years ago

mohammedzee1000 commented 6 years ago

Signed-off-by: Mohammed Zeeshan Ahmed mohammed.zee1000@gmail.com

mohammedzee1000 commented 6 years ago

Successful run:

Creation:

$  oc process -p OS_MASTER_URL="https://os-master-1.example.com:8443"  -f configmaps/os-master-config.yaml | oc apply -f -

$  oc process -p JENKINS_SECRET_NAME=jenkins-token-ck7j8 -f weekly-scan/master-controller.yaml | oc apply -f -

If No weekly scans present:

$ docker logs 51f8d2bdab76
Logged into "https://os-master-1.lon1.centos.org:8443" as "system:serviceaccount:cccp:jenkins" using the token provided.
You have one project on this server: "cccp"
Using project "cccp".
No projects to trigger

If present:

$ docker logs 9cd913be76c1
Logged into "https://os-master-1.lon1.centos.org:8443" as "system:serviceaccount:cccp:jenkins" using the token provided.
You have one project on this server: "cccp"
Using project "cccp".
build "wscan-arrfab-nanoc-latest-1" started
....
mohammedzee1000 commented 6 years ago

FYI you can use oc describe sa/jenkins and pick up token from there.

bamachrn commented 6 years ago

Even though the CI shows as running here, it actually passed. As we have updated the status context, previous context is lost.

mohammedzee1000 commented 6 years ago

@dharmit for why separate config map directory. It is because it is a common configmap, containing dns of openshift master, which has the potential of being used elsewhere in future. Hence i brought it outside

dharmit commented 6 years ago

@mohammedzee1000 with potential future use cases, we can't do things right now. If in future we do end up in a scenario you think we would end up in, we can change things like this then since it's just about doing mkdir; git mv. My concern is the directory structure of our repo. It's already having things everywhere.

mohammedzee1000 commented 6 years ago

I dont get what test is failing here

navidshaikh commented 6 years ago

@mohammedzee1000 : We'll need to update the deployment doc addressing how/when to create these objects in weekly-scan/ folder and their order as well.

mohammedzee1000 commented 6 years ago

Yes, that will be needed

navidshaikh commented 6 years ago

I am dismissing my review and we can proceed further with @dharmit LGTM on it. Dharmit - once the CI is green, please go ahead and merge it.

bamachrn commented 6 years ago

dotests

navidshaikh commented 6 years ago

dotests

navidshaikh commented 6 years ago

dotests

bamachrn commented 6 years ago

dotests

bamachrn commented 6 years ago

dotests-unittests