search

CentOS / container-pipeline-service

Code, infrastructure and deployment backend for the CentOS Container Pipeline backing up build system for registry.centos.org
https://registry.centos.org
GNU General Public License v3.0
49 stars 27 forks source link

Fixes bugs in scanners #626

Closed navidshaikh closed 6 years ago

navidshaikh commented 6 years ago

This changeset fixes bugs in scanners.

  1. Uses yum python API client library to list yum updates

    Stops using system commands and parsing stdout, now uses yum python API client library to list and print the updates in cleaner way.

    Uses a Suppressor for not printing the yum repo updates stdout before printing results.

    Adds ability to list installed version of package, for which updates are available. Adds ability to list the source yum repo.

  2. Adds error checking in rpmverify scanner

    Adds missing sys import Adds formating indexes to be compatible for python version in centos6 images.

  3. Fixes string formatting in misc and capabilities scanner

    Fixes string formatting Uses explicit indexes in string formatting for python version in centos6 image

  1. Uses /usr/bin/python as entrypoint to stay compatible with centos6 images

    Since python is installed at /usr/bin/python in CentOS6 image, and earlier we were using /bin/python , which is unavailable in CentOS6 image. CentOS7 image has needed symlinks to stay compatible with either /usr/bin/python or /usr/bin/python.

dharmit commented 6 years ago

LGTM, waiting for CI.