search

CentOS / container-pipeline-service

Code, infrastructure and deployment backend for the CentOS Container Pipeline backing up build system for registry.centos.org
https://registry.centos.org
GNU General Public License v3.0
49 stars 27 forks source link

Stops triggering builds for configChange of master-job template #636

Closed navidshaikh closed 6 years ago

navidshaikh commented 6 years ago

All the pipelines have master-job template set for building at OpenShift.

Any single change in template, is identified as configChange by oc.

In IndexReader, we see if a buildConfig / master-job for pipeline is configured, while running seed-job (which syncs index with pipelines on OpenShift).

Update in tempaltes can be of two types: A- Update in parameters which affects the resultant builds B- Update in parameters which affects service side workflow and behavior

The build should only be re-triggered in case A.

However, those changes as mentioned in A, are already taken care by poll SCM config in master-job of pipeline.

Thus, we need to prevent re-triggering builds in case of B.

navidshaikh commented 6 years ago

We dont need to remove this.

This is needed to trigger the build of the pipeline when its “created” for the first time in OpenShift.

On Fri, 21 Sep 2018 at 11:48 AM, Bamacharan Kundu notifications@github.com wrote:

@bamachrn requested changes on this pull request.

We need to remove

Trigger:

  • type: ConfigChange

from both the templates as well

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CentOS/container-pipeline-service/pull/636#pullrequestreview-157557383, or mute the thread https://github.com/notifications/unsubscribe-auth/ACZNaPn7fjXlHxnnq_vEzTKy9xp6I7Erks5udISzgaJpZM4WzgPi .

-- Navid Shaikh Composed on handheld device.

navidshaikh commented 6 years ago

dotests

bamachrn commented 6 years ago

dotests

bamachrn commented 6 years ago

dotests

navidshaikh commented 6 years ago

Pasting the test results

Number of projects to be updated/created: 3
Starting index processing with
Batch size=5
Batch polling Interval (in seconds)=30
Batch outstndaing builds cap count=3

Processing projects batch: ['devcloud-wget-latest', 'bamachrn-python-release', 'nshaikh-build-fail-test-latest1']

buildconfig.build.openshift.io "devcloud-wget-latest" unchanged

buildconfig.build.openshift.io "bamachrn-python-release" unchanged

buildconfig.build.openshift.io "nshaikh-build-fail-test-latest1" configured

Processing weekly scan projects..
buildconfig.build.openshift.io "wscan-devcloud-wget-latest" unchanged

buildconfig.build.openshift.io "wscan-bamachrn-python-release" unchanged

buildconfig.build.openshift.io "wscan-nshaikh-build-fail-test-latest1" unchanged

This 3rd of seed-job where it identified a project as configured, however the build for same is not started. (earlier behavior: if configured, start-build of the pipeline)