search

CentOS / container-pipeline-service

Code, infrastructure and deployment backend for the CentOS Container Pipeline backing up build system for registry.centos.org
https://registry.centos.org
GNU General Public License v3.0
49 stars 27 forks source link

Removes daemonset and reference scanning module from slave image #644

Closed navidshaikh closed 6 years ago

navidshaikh commented 6 years ago

Since we are adding complete source code of service in slave container image, we don't need to explicitly avail the scanning module via a different container's volume.

In this changeset, we have removed the daemonset template altogether, and in scanning stage of each pipeline, we are availing the scanning module via docker volume from slave container image itself.

Changes:

  1. Remove daemon-set/ dir
  2. Move Dockerfiles/ccp-openshift-scan/scanning/ to ccp/ module
  3. Remove Dockerfiles/ccp-openshift-scan/ dir
  4. Define /opt/ccp-openshift/ccp/scanning as volume from slave image
  5. In each scanners stage, create container from image under test sharing a volume from slave container image's scanning module volume, and invoking scanner from the shared volume.
  6. Remove reference of daemon-set from README.md
  7. Update the weekly-scan template as pointed in point 5.
dharmit commented 6 years ago

dotests

bamachrn commented 6 years ago

dotests

navidshaikh commented 6 years ago

@bamachrn @dharmit @mohammedzee1000 : I've rebased this PR against origin/openshift branch.

bamachrn commented 6 years ago

dotests

bamachrn commented 6 years ago

dotests

navidshaikh commented 6 years ago

dotests

navidshaikh commented 6 years ago

This PR needs an update. On a node where multiple slave containers are running docker ps -qf name=${slave_container_name} is returning more than one container ids, while in the template, we'd need only 1 container id.