CentOS / sig-cloud-instance-build

CentOS Cloud Instance SIG: Metadata to build & release instances
362 stars 168 forks source link

Fix the format of org.label-schema.build-date #151

Closed 2opremio closed 4 years ago

2opremio commented 5 years ago

The convention draft clearly states that org.label-schema.build-date should be in RFC 3339 format:

This label contains the Date/Time the image was built. The value SHOULD be formatted according to RFC 3339.

Addresses https://github.com/CentOS/sig-cloud-instance-images/issues/100#issuecomment-468344953

centos-ci commented 5 years ago

Can one of the admins verify this patch?

2opremio commented 5 years ago

BTW, this is causing problems for Weave Flux. See https://github.com/weaveworks/flux/pull/2084

hiddeco commented 5 years ago

In addition, the Label Schema Spec has been deprecated and should be replaced (or accompanied) by its successor; the OCI Annotation Spec. This should however be addressed in a separate PR.