CentaurusInfra / mizar

Mizar – Experimental, High Scale and High Performance Cloud Network https://mizar.readthedocs.io
https://mizar.readthedocs.io
GNU General Public License v2.0
112 stars 50 forks source link

Fix for bootstrap.sh script to update kernel headers to the latest kernel if ver>=5.6.0 #534

Closed click2cloud-team4 closed 2 years ago

click2cloud-team4 commented 3 years ago

What type of PR is this?

bug fix

What this PR does / why we need it: This PR will Update kernel headers if kernel version >5.6.0

Which issue(s) this PR fixes: Fixes #507

How was this tested?: Manual Tested: we have tested this PR on GCE using arktos-up and kind-setup on following kernel version

vinaykul commented 2 years ago

This PR does not work. apt search command is not the right command to use to list installed packages, rather it is used for searching available packages. Also the code to check for version should really be part of kernel update.

This PR is rejected due to lack of thoughtfulness in the changes being proposed, due to various quality issues and from history the general difficulty in getting any meaningful work done from Click2Cloud contributors. We will fix this issue ourselves.