search

CentaurusInfra / mizar

Mizar – Experimental, High Scale and High Performance Cloud Network https://mizar.readthedocs.io
https://mizar.readthedocs.io
GNU General Public License v2.0
112 stars 50 forks source link

Refactor and cleanup Mizar CNI driver trace logging #616

Closed vinaykul closed 2 years ago

vinaykul commented 2 years ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind design /kind feature /kind bug /kind cleanup /kind documentation

What this PR does / why we need it: This just cleans up the code and makes it easier to add Error response according to CNI spec (next PR if it works correctly) and also add CHECK in the future (most likely after this release). I don't see issue Yunwen saw with arktos ( https://github.com/CentaurusInfra/mizar/issues/609 ) in upstream. I'll look at Arktos next.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: