search

Center-for-Digital-Narrative / elmcip

Electronic Literature as a Model of Creativity and Innovation in Practice (ELMCIP) is a collaborative research project funded by Humanities in the European Research Area (HERA) JRP for Creativity and Innovation built in Drupal
https://elmcip.net
4 stars 0 forks source link

Media Flickr does not support all URL types from Flickr #182

Open AlvaroSeica opened 8 years ago

AlvaroSeica commented 8 years ago

Adding content from Flickr does not work for some kind of content. Might be related to new address types added by Flickr.

Media that does not work

How to test

Test url of the type listed above.

Original report

Spin off from issue #2

Media module does not support:

  • Filckr Short or Long URLs
  • Sildeshare URLs

Check issue #43, and see if Drupal already has module integration for Issuu.com [API http://developers.issuu.com/api/]

elmcip commented 8 years ago

Media: Slideshare looks more or less abandoned https://www.drupal.org/node/2070931

elmcip commented 8 years ago

Looks like @steinmb was one of the people making commits on the module. Would be great to get this one working.

steinmb commented 8 years ago

Media: Slideshare looks more or less abandoned https://www.drupal.org/node/2070931

Yes that module have not been given love for a long time. If that patch though work, we can apply it locally to elmcip and let it live there to make slideshare work again.

Flickr example on what that does not work?

There might be stuff related to "new" short url format but at least this seems to work:

add_file___elmcip

add_file___elmcip

content___elmcip

enjoying_this_beautiful_day_on_the_bike__the_view_while_resting_under_a_tree ___elmcip

steinmb commented 8 years ago

Tested on our master branch. Added URL: http://www.slideshare.net/slidecomet/5-storytelling-lessons-from-superhero-stories/7-They_have_human_emotionsdesires_and

It get added, but it seems not know how to render it. I falls back on a link to the slideshare.

61412100___elmcip

steinmb commented 8 years ago

BTW is http://elmcip.dev/story/elmcip-research-project-goals-results-and-impact-presentation-remediating-social-conference the only slideshare use we have?

AlvaroSeica commented 8 years ago

@steinmb don't know. can you make a search on files by pointer slideshare.net?

steinmb commented 8 years ago

You can try and filter on your installation: http://elmcip.dev/admin/content/file. I see only one, and it is not even a kb record.

steinmb commented 8 years ago

Dug this out of the db::

    +------+-----+----------+-------------------------+---------------------+----------+--------+------------+---------+
    | fid  | uid | filename | uri                     | filemime            | filesize | status | timestamp  | type    |
    +------+-----+----------+-------------------------+---------------------+----------+--------+------------+---------+
    | 1940 |  35 | 14850408 | slideshare://s/14850408 | document/slideshare |        0 |      1 | 1351164127 | default |
    +------+-----+----------+-------------------------+---------------------+----------+--------+------------+---------+
    1 row in set (0.00 sec)
steinmb commented 8 years ago

@hannahackermans This issue will not be fixed before someone do more testing. Feel like testing on test.elmcip.net? We only need feedback on what work and what no work on Flickr. Read the entire thread for more information.

AlvaroSeica commented 8 years ago

I'll test. Are we agreeing then that we will not support Slideshare as there is not users using it?

steinmb commented 8 years ago

+1 from me that we remove support for Slideshare.

elmcip commented 8 years ago

Make it so.

On 03 Jun 2016, at 15:05, Stein Magne Bjørklund notifications@github.com wrote:

+1 from me that we remove support for Slideshare.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/elmcip/elmcip/issues/182#issuecomment-223573178, or mute the thread https://github.com/notifications/unsubscribe/AFj5jSXVmPVW9SxGEAFcrzk8zcrq0RaEks5qICaDgaJpZM4IQ4G4.

steinmb commented 8 years ago

Removed use of elmcip.net/file/1940 and and file entity it self. We should be good to remove slideshare support now.

steinmb commented 8 years ago

199 removed Slideshow support from ELMCP. Renamed this issue to be only about Flickr AND we need users to tell me what type of Flickr content that does not work.

steinmb commented 8 years ago

This issue will not be addressed before someone volunteer to do more testing. @hannahackermans do you feel up to the task of testing flickr on test.elmcip.net? We need feedback on what work and what no work on related to images/slideshows from Flickr. For more information have a (bit confusing) read through the thread. If you do, assign the issue to your self so every can see you are working on it and don't try to test it.

hannahackermans commented 8 years ago

@steinmb I did some tests and the only thing that seems to work is a URL in the format: https://www.flickr.com/photos/[accountname]/[number]/ This is the form that also worked for you earlier in the thread. However, if you get to a photo in a different way, for example by using "explore" or using the search entry, the URL will look different and give an error. The above is about the URLs in the address bar.

https://www.flickr.com/photos/brandonsphoto/27936543646/ normal-url-flickr

https://www.flickr.com/photos/brandonsphoto/27936543646/in/explore-2016-06-29/ url-flickr

I also tested flickr's links for sharing photos and albums using the "share" button and then either the "share", "embed" or "bbcode". not of these work, but maybe they were not meant to work? In the text underneath the URL field it mentions the embed function, so I thought that might work or people might try it.

https://flic.kr/s/aHsjFE6gB7 share-share-flickr

share-embed-flickr share-bbcode-flickr

an album URL is also not accepted. (and neither are the share and embed function) https://www.flickr.com/photos/m00k/albums/72157594477789563 album-share-flickr

One final note, as I understand from the thread the slideshare option has been removed. In that case, slideshare should also be removed from "Supported internet media providers".

I hope this is useful, and please let me know if I need to test/show you something else.

steinmb commented 8 years ago

Great testing :) Could you also provide the URL (as text) that you tested so we can re-test the URL when the issue is addressed?

Note: bbcode and embed code should not work, so failing on them is normal.

hannahackermans commented 8 years ago

Thank you :) I updated the comment to include the URLs, except bbcode and embed code.

If I may ask: if embed code is not supposed to work, why does it say "many media providers also support identifying media via the embed code used to embed the media into external websites"? I know it is not really an instruction to use embed code but for me that line seems to suggest I could do that on elmcip kb.

steinmb commented 8 years ago

Nope. The embed thingy have another use case. media_flickr parse a URL address, accessing Flickr through the Flickr API, getting meta data like title, descr. and so on and store this together with a thumbnail.

steinmb commented 8 years ago

Moving to 1.23. 1.21 and 1.22 have enough issues to review and test.

steinmb commented 7 years ago

This improve album support and fixes small issues:

commit a732095d6cd7f02ff91002abc910a790bcdb984d Module update Media: Flickr 7.x-2.0-alpha3+18-dev -> 7.x-2.0-alpha4

steinmb commented 7 years ago

More updates in supported URL in alpha 5:

commit 04e45679853f1104a2f0558e400d129be38fbc48 Author: Stein Magne Bjorklund steinmb@smbjorklund.com Date: Tue Sep 5 13:23:49 2017 +0200

Module updated: media_flickr 7.x-2.0-alpha4 -> 7.x-2.0-alpha5

https://www.drupal.org/project/media_flickr/releases/7.x-2.0-alpha5