Improve event vertical flow

Center-for-Digital-Narrative / elmcip

Electronic Literature as a Model of Creativity and Innovation in Practice (ELMCIP) is a collaborative research project funded by Humanities in the European Research Area (HERA) JRP for Creativity and Innovation built in Drupal

https://elmcip.net

4 stars 0 forks source link

Improve event vertical flow #256

Closed steinmb closed 7 years ago

steinmb commented 8 years ago

Spin out from #242 that contain a full scope overview and what made it into to v1.21.

Scope

Make sure that all elements that we can populate are correctly positioned.

How to test

Make everyone happy when viewing events.
Load different event nodes and take a good look. Try to spot page elements out of place.
Populate all elements, some, variants and see if you are able to break layout or make it look really bad.

steinmb commented 8 years ago

Time to attack event content type view modes. Aiming to remove both teaser and full content and only keep the default. See no use for more then the default.

Backup of full content before removal

screen_shot_2016-10-31_at_16_15_35

steinmb commented 8 years ago

Here is a example on event with all the fields populated

screen_shot_2016-10-31_at_21_06_28

steinmb commented 8 years ago

Here is one thing we need to address.

screen_shot_2016-10-31_at_21_06_28

steinmb commented 8 years ago

This addresses the addresses (pardon the pun)

8b3ac82 Stein Magne Bjorklund on 31/10/2016 at 21:39 [elmcip.net] Issue 256 Vertical margins used for multiple location/addresses.

In 2 branches: HEAD, issue_256

electronic_literature__a_matter_of_bits___elmcip_-__private_browsing_

steinmb commented 8 years ago

Small change, not revolutionary. Would like us to see do this better but I think this is OK for now.

8b3ac82 Stein Magne Bjorklund on 31/10/2016 at 21:39 [elmcip.net] Issue 256 Vertical margins used for multiple location/addresses.

In 3 branches: HEAD, issue_256, origin/issue_256

Before change

After change

steinmb commented 8 years ago

Then we have this ugly thingy. It is just as bad in all content types. The record meta data.

banners_and_alerts_and_electronic_literature__a_matter_of_bits___elmcip_-__private_browsing_

steinmb commented 8 years ago

0c538f6 Stein Magne Bjorklund on 01/11/2016 at 00:38 [elmcip.net] Issue 256 Move event meta data field to a wrapper div to easy styling.

All fields moved inside this should look and position correct.
Meta data is vertically separated with double margin to visually set it a little apart user entered content.

In 3 branches: HEAD, issue_256, origin/issue_256

Example after change

_ran_-_real_audio_netliterature___elmcip_-__private_browsing_

steinmb commented 8 years ago

Time to get more eyes on events. Moved following commits into master and staged on test.

cc15b57 Issue 256 Move event meta data field to a wrapper div to easy styling. d9851d4 Issue 256 Cange date formatter from long to dmy 07c16d6 Issue 256 Vertical margins used for multiple location/addresses. 7bbd3e4 Issue 256 Clean up comments. aa514cc Issue 256 Remove event full content view mode 31d580d Issue 256 Remove event teaser view mode

AlvaroSeica commented 7 years ago

@steinmb https://test.elmcip.net/event/isea2015-disruption good changes, all good.

AlvaroSeica commented 7 years ago

Though, for consistency /Move event meta data field to a wrapper div to easy styling/ should something addressing all nodes in the KB. But not urgent now...

steinmb commented 7 years ago

Though, for consistency /Move event meta data field to a wrapper div to easy styling/ should something addressing all nodes in the KB

Yes. the plan is to do so though we need to check them all one by one. #242 give a birds eye view of the issues.