Platform - remove promoted to front page status from a set of nodes

steinmb commented 7 years ago

Someone with permission have tagged a set of nodes as published to front page. Not sure if this is in on purpose. As far as I know do we not use this node tag in any of the content listings.

Suggested fix

[x] Remove published to front page
[x] Remove https://elmcip.net/node
[ ] Audit permissions to use this on KB content.

How to test

Only story content types should have the promote and sticky option on both create new and edit existing.
Users with access to /admin/content should not have the option to demote, promote, sticky and unsticky.

Content overview page - Before change

fullscreen_12_09_2017__12_57

Content overview page - After change

fullscreen_12_09_2017__12_59

Nodes updated

SELECT nid, title, type FROM node WHERE promote = 1 AND type != 'story';

+-------+----------------------------------+-------------------+
| nid   | title                            | type              |
+-------+----------------------------------+-------------------+
|  9970 | Processing                       | platform_software |
| 10254 | Linux                            | platform_software |
| 10255 | Cascading Style Sheets (CSS)     | platform_software |
| 10256 | Flash                            | platform_software |
| 10257 | PHP                              | platform_software |
| 10258 | JavaScript                       | platform_software |
| 10259 | Java                             | platform_software |
| 10260 | Mac OS X                         | platform_software |
| 10261 | PlayStation                      | platform_software |
| 10263 | The Wii                          | platform_software |
| 10265 | BASIC                            | platform_software |
| 10267 | Extensible Markup Language (XML) | platform_software |
| 10268 | BlueJ                            | platform_software |
| 10277 | Commodore 64                     | platform_software |
| 10278 | Twine                            | platform_software |
| 10279 | Gameboy                          | platform_software |
| 10280 | MySQL                            | platform_software |
| 10281 | jQuery                           | platform_software |
| 10282 | Amiga                            | platform_software |
| 10283 | Xbox                             | platform_software |
| 10284 | StorySpace                       | platform_software |
| 10285 | Blender                          | platform_software |
| 10296 | ALGOL                            | platform_software |
| 10297 | Ruby                             | platform_software |
| 10298 | Drupal                           | platform_software |
| 10299 | Python                           | platform_software |
| 10300 | Google Chrome                    | platform_software |
| 10301 | DSpace                           | platform_software |
| 10302 | Netscape                         | platform_software |
| 10303 | ZX Spectrum                      | platform_software |
| 10304 | WordPress                        | platform_software |
| 10305 | FORTRAN                          | platform_software |
| 10306 | Internet Explorer                | platform_software |
| 10307 | SCALAR                           | platform_software |
| 10308 | Shockwave                        | platform_software |
| 10309 | Ebay                             | platform_software |
| 10310 | Facebook                         | platform_software |
| 10311 | HyperCard                        | platform_software |
| 10312 | Apple 2                          | platform_software |
| 10313 | RiTa                             | platform_software |
| 10314 | Squeak                           | platform_software |
| 10315 | iPhone                           | platform_software |
| 10316 | Google Earth                     | platform_software |
| 10317 | Spatterlight                     | platform_software |
| 10318 | Twitter                          | platform_software |
| 10319 | Vimeo                            | platform_software |
| 10320 | C++                              | platform_software |
| 10321 | Google Maps                      | platform_software |
| 10322 | Open StreetMap                   | platform_software |
| 10323 | iPad                             | platform_software |
| 10324 | YouTube                          | platform_software |
| 10325 | Layar                            | platform_software |
| 10327 | Android                          | platform_software |
| 10328 | DHTML                            | platform_software |
| 10329 | Atari                            | platform_software |
| 10361 | iTunes                           | platform_software |
| 10362 | Quicktime                        | platform_software |
| 10364 | Instagram                        | platform_software |
+-------+----------------------------------+-------------------+
58 rows in set (0.00 sec)

AlvaroSeica commented 7 years ago

I saw it, but in practice, promoted to FP doesn't do nothing, right?

steinmb commented 7 years ago

It will if we decide to use it. Example would be functionality discussed in #47. In other words we should never use it. This issue will try to mitigate this by removing permissions to this until we need it though we need to write special permission for this. The current permission scope is to wide.

AlvaroSeica commented 7 years ago

Oh I get you, now I should go thru each of those 58 records and undo the promote to FP, right? And then we should also revoke the permissions, that is, only admins and editors can promote to front.

AlvaroSeica commented 7 years ago

I think the majority was platforms and done by students in 207 last year, so it was an error. Others, such as https://elmcip.net/story/335-scholars-and-artists-submitted-proposals-elo2015 was done by me, since I think the only way i can create news (story content type) to pop-up in the news box in the homepage, is by creating a "story" and then promote them to FP. Correct me if im wrong.

AlvaroSeica commented 7 years ago

Uff... 58 records. Cleaned them all. Now... everything living here https://elmcip.net/node are stories, meaning, records that (can't see where to find the nodes of which) pop-up in the NEWS box in the homepage

steinmb commented 7 years ago

Thank you! Confirm that you got them all:

SELECT nid, title, type FROM node WHERE promote = 1 AND type != 'story';

Empty set (0.00 sec)

I think we can leave the story nodes as they are. They are not a part of the KB anyway. If they cause problem will I address them with SQL magic.

AlvaroSeica commented 7 years ago

Good! But we should still address the permissions issue then.

Audit permissions to use this on KB content.

steinmb commented 7 years ago

One down.

commit 9e54051251cbf65921deb5b010800e0a2c251cd0 Author: Stein Magne Bjorklund steinmb@smbjorklund.com Date: Tue Sep 12 11:30:33 2017 +0200

Issue 269 - Remove /node and change news path to /news

Drupal comes with a default front page example.com/node. ELMCIP
uses another front page. ELMCIP also uses a view that pulls out
the nodes that is "promoted" to front page (views_recent_posts)
that create a short list on the front page + exposes all story
types, promoted or not.

This remove /node and changes news to /news to prepare us to remove
the block from front page and replace it with a menu link.

steinmb commented 7 years ago

@AlvaroSeica this is the last task in this issue. Remove promote and sticky to all add or edit nodes except for Story.

Note: To make sure they cannot be turned on by going to /admin/content, administrative editor are allowed. I had to remove: demote, promote, sticky and unsticky. Here I had to remove it for all content types. These are batch options in a single list. No other way. This can completely removed in the future if we end up not liking this bit of the change.

Content overview page - Before change

fullscreen_12_09_2017__12_57

Content overview page - After change

fullscreen_12_09_2017__12_59

ommit 935b41b86a92e9d627b0b2b733ed128eb271ef38 Author: Stein Magne Bjorklund steinmb@smbjorklund.com Date: Tue Sep 12 13:08:08 2017 +0200

Issue 269 Remove promote and sticky from all except story

Confuse some users with the power of to promote articles and we should
also make sure we do not populate nodes with properties we should not
have.

Also remove this option from the content overview page for the users
to access it.

elmcip commented 6 years ago

Is there a reason this issue is open?

steinmb commented 6 years ago

Checking..... No, I fixed it back in sept. Good catch.

Center-for-Digital-Narrative / elmcip