search

Center-for-Digital-Narrative / elmcip

Electronic Literature as a Model of Creativity and Innovation in Practice (ELMCIP) is a collaborative research project funded by Humanities in the European Research Area (HERA) JRP for Creativity and Innovation built in Drupal
https://elmcip.net
4 stars 0 forks source link

Remove Google analytics permissions from feature to allow sites to remove module #418

Closed steinmb closed 5 years ago

steinmb commented 5 years ago

Our permissions list the modules as a dependency allowing us to deploy permission settings to production. This is all good but on the other hand blocks sites from uninstalling it if they do not use google analytics.

Suggested fix

steinmb commented 5 years ago

This should address the issue.

commit 00d3ad03fb0c6a2c823e6759deb24799b243005c (HEAD -> master, origin/master, origin/HEAD) Author: Stein Magne Bjorklund steinmb@smbjorklund.com Date: Mon May 27 13:25:02 2019 +0200

Issue 418 Remove google analytics development settings

commit 6177b3c145a06640e55ba8f83b5ee9ae8fbf8343 Author: Stein Magne Bjorklund steinmb@smbjorklund.com Date: Mon May 27 13:19:36 2019 +0200

Issue 418 Remove google analytics tracking settings

commit 1ccd1a6e535f5e00efe4921b721e21261580d675 Author: Stein Magne Bjorklund steinmb@smbjorklund.com Date: Mon May 27 13:10:05 2019 +0200

Issue 418 Remove google analytics permissions settings

Allow sites to uninstall module without having to struggle
with dependency issues.
steinmb commented 5 years ago

Verified working on sister site: https://machinevision.elmcip.net/