Center-for-Proteomics-and-Metabolomics / GlycoDash

GlycoDash is an R Shiny dashboard for processing protein glycosylation data obtained from LaCyTools or SkyLine.
MIT License
2 stars 0 forks source link

Data import: adding clusters and metadata is slow #12

Closed stainawarijar closed 1 year ago

stainawarijar commented 1 year ago

In the data import tab, adding the clusters and adding the metadata are both very slow, especially for larger summary files.

Try if this can be made faster.

stainawarijar commented 1 year ago

In adding the clusters and metadata, the problem seems to be that passing the resulting data between the different modules is slow.

stainawarijar commented 1 year ago

It could also be that the code for the spectra curation is slow. When clusters or metadata is added in the data import tab, the resulting data is returned to the next module (spectra curation) and then processed.

This could also explain why changing the ppm values in the spectra curation is slow?

stainawarijar commented 1 year ago

I used the following in "mod_spectra_curation.R" to check:

    observe({
      req(LaCyTools_summary())
      browser()
    }, priority = 20)

The function "check_analyte_quality_criteria" appears to be what is slow.

stainawarijar commented 1 year ago

The function "check_analyte_quality_criteria" depends on other functions.

The function "apply_chosen_criteria" is slow.