Center-for-Proteomics-and-Metabolomics / GlycoDash

GlycoDash is an R Shiny dashboard for processing protein glycosylation data obtained from LaCyTools or SkyLine.
MIT License
2 stars 0 forks source link

Curated spectra plots not always shown in data processing report. #14

Closed stainawarijar closed 1 year ago

stainawarijar commented 1 year ago

The figure with the spectra curation results (% of passing spectra) is no longer shown in the data processing report.

stainawarijar commented 1 year ago

The spectra curation is still performed correctly (confirmed by checking which samples are in the normalized data).

stainawarijar commented 1 year ago

The plots are only shown when there are more than 4 clusters.

stainawarijar commented 1 year ago

In Report2.Rmd, params$curated_spectra_plot is somehow NULL when it should not be.

Perhaps in the params list in mod_export.R, the line curated_spectra_plot = try_call(results_spectra_curation$plot()) is not working correctly.

stainawarijar commented 1 year ago

Fixed in v1.2.1 by replacing results_spectra_curation$plot() with results_spectra_curation$plot.