Center-for-Proteomics-and-Metabolomics / GlycoDash

GlycoDash is an R Shiny dashboard for processing protein glycosylation data obtained from LaCyTools or SkyLine.
MIT License
2 stars 0 forks source link

Switching between analyte curation methods #51

Closed stainawarijar closed 10 months ago

stainawarijar commented 1 year ago

When switching between analyte curation methods, sometimes the wrong figures are shown.

Example: when analyte curation is first performed per biological group, and then performed on all data, the plots for the curation per group are still shown.

The normalized data does seem to contain the correct results.

stainawarijar commented 1 year ago

Fixed figures.

stainawarijar commented 1 year ago

Performing analyte curation one way and then choosing another method now works correctly as long as you don't click the cluster tabs.

When clicking the cluster tabs after curation, and using another curation method, the data with passing analytes is somehow not updated correctly and the normalized data remains the same. The correct figures are still shown in the analyte curation tab.

stainawarijar commented 12 months ago

Selecting/deselecting checkboxes does not work after curating analytes a second time, regardless of whether all cluster tabs were clicked previously.

stainawarijar commented 12 months ago

For now I will make it possible to perform analyte curation only once (button is disabled afterwards, implemented in commit 281b5c ).

Will create a separate branch for this bug.

stainawarijar commented 11 months ago

Fixed by generating unique tab ids each curation round.