search

Center-for-Research-Libraries / crl-serials-validator

Validate bibliographic and holdings data for shared print.
GNU General Public License v3.0
0 stars 1 forks source link

look for MARC and ISSN databases in validator data folder #13

Closed nflorin closed 2 years ago

nflorin commented 3 years ago

Currently the program creates a folder called "CRL MARC Machine" in the user's home directory and creates the local MARC database there, and also searches for the ISSN database there. The scripts instead should default to the data folder first.

To maintain compatibility with older installations, and with people who also use the MARC Machine, the scripts should follow this order when looking for (and possibly creating) the MARC database:

  1. Look for the database in data.
  2. Look for the database in home/username/CRL MARC Machine or the Windows/Mac equivalent.
  3. Create the database in data.
AndyElliottCRL commented 2 years ago

This is a good enhancement, makes it more portable (assuming this is for '/path_to_Validator_installation/data/' so everything is self-contained). IMHO everything the Validator creates/uses (outside Python imports) should be inside its directory somewhere.

nflorin commented 2 years ago

I ended up doing something a bit more complicated, basically adding a third option to look for a CRL folder in the user's home directory, then to look in the user's default data directory (based on their OS) for the relevant files. This is to make the Validator slightly more future-proof, but at the moment shouldn't change its operation at all.