search

Center-for-Research-Libraries / crl-serials-validator

Validate bibliographic and holdings data for shared print.
GNU General Public License v3.0
0 stars 1 forks source link

Semi-duplication of "repeated" and "unique" fields #46

Closed nflorin closed 2 years ago

nflorin commented 2 years ago

In the title_dict there are both "unique" and "repeated" fields for the local_oclc, wc_oclc, and holdings_id. So:

    base_title_dict = {
        [...]
        'holdings_id_repeated': '',
        'holdings_id_unique': '',
        [...]
        'local_oclc_repeated': '',
        'local_oclc_unique': '',
        [...]
        'wc_oclc_repeated': '',
        'wc_oclc_unique': '',
        [...]
    }

These are essentially duplicates, in that they say the same thing from opposite directions. We should remove one set of them in order to avoid errors.

nflorin commented 2 years ago

In the main dict, keys that are analysis (rather than just data) are negative in the context of validation, something like form_not_print or invalid_carrier_type. This means that, to encourage consistency, we should remove the foo_unique formulations.

nflorin commented 2 years ago

I removed the foo_unique values as a part of fixing issue #34.