Center-for-Research-Libraries / vufind

CRL Implimentation of VuFind frontend for FOLIO. A library resource discovery portal designed and developed for libraries by libraries
GNU General Public License v2.0
1 stars 0 forks source link

Refactor link style #114

Closed KimSarabia closed 2 years ago

KimSarabia commented 2 years ago

Description

Screen Shot 2022-05-25 at 12 19 03 PM
ryan-jacobs commented 2 years ago

We may consider leveraging some www styles and concepts here. It looks like we went though a similar analysis there and ended up using underline styles while maintaining branding colors for links. This was a careful process though, as we only wanted the change styles for inline links while allowing other cues (such as menu containers, buttons, etc.) to continue to communicate links elsewhere. So text-decoration: underline rules needed to be carefully targeted and/or omitted depending on the parent container(s).

We don't have a full issue for this on www, but this commit may be a useful reference (not for directly repurposed styles, but to reveal some of the thought process): https://github.com/Center-for-Research-Libraries/crl-drupal-www/commit/9680c726ec53733acd7500f7850181751da5509d

Of course, we need to verify that all changes align with accessibility rules and best practices.

ryan-jacobs commented 2 years ago

We decided to consolidate to move this into #73

ryan-jacobs commented 2 years ago

73 closed this