Center-for-Research-Libraries / vufind

CRL Implimentation of VuFind frontend for FOLIO. A library resource discovery portal designed and developed for libraries by libraries
GNU General Public License v2.0
1 stars 0 forks source link

OAI harvest process is not persisting correct end date information #160

Closed ryan-jacobs closed 2 years ago

ryan-jacobs commented 2 years ago

This issue has been active for some time already, but it was opened as a vufindharvest project issue:

Here is the issue: https://github.com/vufind-org/vufindharvest/issues/7 And the PR that resulted: https://github.com/vufind-org/vufindharvest/pull/8 And a follow-up PR related to test fixes: https://github.com/vufind-org/vufindharvest/pull/10

It's best to direct all energy into those active threads, but I also want to track this in our local project.

ryan-jacobs commented 2 years ago

This issue is fairly detailed and involved, but it's moving forward nicely in the vufindharvest repo!

ryan-jacobs commented 2 years ago

The vufindharvest PRs have been addressed and merged. This has also triggered a new release of vufindharvest:

https://github.com/vufind-org/vufindharvest/blob/v5.0.0/CHANGELOG.md

I do not think that this new release is officially targeted toward VuFind 8.x as some changes in the release are intended for alignment with VuFind 9.x standards (see https://github.com/vufind-org/vufindharvest/pull/9, which was merged in the release as well). The most noteworthy additional change in the release is the requirement of php 7.4.1, which I suspect will not be enforced until Vufind 9.x. This does not prohibit us from using the new release in our 8.x install though, we just need to work through some php version constraints across other dependencies in composer.json. Our production environment(s) already support php >= php 7.4.1.

ryan-jacobs commented 2 years ago

The only other complication from the php 7.4.1 requirement was pear/validate_ispn, which has been updated now in composer.lock along with vufindharvest in https://github.com/Center-for-Research-Libraries/vufind/commit/36ec38503411322d0de0c30d754a7e8916bb0781.

Of course a composer install operation will be needed upon deployment.

ryan-jacobs commented 2 years ago

https://github.com/Center-for-Research-Libraries/vufind/commit/36ec38503411322d0de0c30d754a7e8916bb0781 addresses this.