Closed msenn closed 6 years ago
Thanks for seeing that. I've fixed that up. Let me know if there's anything else. Version 1.3-0.0 is the new version. Available on GitHub now and will post to CRAN shortly and hopefully available there in a day or two.
Thanks, Damian, for looking into this. As far as I can tell, the non-NA genders are now populated correctly.
May I ask what behavior you've chosen for the cases where gender is NA? I can think of multiple options that seem sensible:
Possibly, the information on the chosen behavior could be included in the documentation of the function.
Good idea (to include in documentation).
Current it just randomly samples a gender/ethnicity and replaces the NA with that. https://github.com/CenterForAssessment/randomNames/blob/master/R/randomNames.R#L61-L62
When calling
randomNames(gender = g)
on a gender vector that containsNA
s, the generated names do no longer represent gender correctly: