CenterForDigitalHumanities / Gallery-of-Glosses

Create a system of well-defined references to historical commentaries and their content.
https://gog-public-site.vercel.app
1 stars 1 forks source link

Issue 19 Added new pages, UI Overhaul with Sidebar, Dark/Light Mode, and Responsive Design #37

Closed TheTuTran closed 8 months ago

TheTuTran commented 9 months ago

issue #19

Description

  1. Added pages for About the project, description of resources, goals
  2. Implemented a toggle for dark/light mode to cater to user preferences.
  3. Added a sidebar for easier navigation. Integrated a simple navbar and footer.
  4. Made design responsive for compatibility across devices: phones, smaller laptops, and desktops.

Before Screenshots image

After Screenshots image image

edit:

  1. Added a simple landing page with mobile, medium screen responsiveness.
  2. Added pages for current links on sidebar to prevent 404 error.
  3. Added navbar for mobile view to swap pages.

image

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gog-public-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 1:56am
AbhilashKotha commented 9 months ago

I have tested the app and I have the below comments and questions.

  1. Is it a design choice to have the landing page empty?
image
  1. The light theme does not work well when there is an error. (I am assuming that the retrieval of glosses is not yet implemented and hence 404 error)
image
  1. In smaller screens, the navigation bar on the left disappeared and I did not find a way to move between pages. Is there any other way/
image
AbhilashKotha commented 9 months ago

@TheTuTran Seems like my comments are addressed, will do more testing on it. For now, can you please check the checklist shared by Dr. Holdener for the draft PR and make the necessary changes? Thanks.