CenterForDigitalHumanities / Gallery-of-Glosses

Create a system of well-defined references to historical commentaries and their content.
https://gog-public-site.vercel.app
1 stars 1 forks source link

issue #16 Add page to browse/search for named glosses #38

Closed TheTuTran closed 8 months ago

TheTuTran commented 8 months ago

Steps to run:

  1. run npm i in the directory to install all dependencies.
  2. run npm run dev and open up localhost:3000 on browser of choice
  1. Use the navigation bar or button on home screen to go to the browse glosses page.

New Features:

  1. Table with glosses
    • Added function to search glosses by name
    • Added function to query for all properties with matching targetId
    • Added function to clean up the returned properties
    • Added classes for glosses and validators using zod
    • Mobile responsive, but table looks a little weird when expanding text.
    • Users can't change the pagination on the table while the table is still loading glosses
  2. Added [slug] page for gloss instance viewing

current state:

image

image

image

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gog-public-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2023 5:50pm
AbhilashKotha commented 8 months ago

@TheTuTran It's working well as shown in the demo.

Is it intentional to have browse by book default when clicking on browse glosses? My suggestion is either show all glosses or have hyperlinks or buttons for browse by book, theme or tag

image

AbhilashKotha commented 8 months ago

@TheTuTran all the other things are working fine. We can merge this once my question is answered.