Bring over parsing design

[thehabes]

Newberry Design:

T-PEN Design:

[cubap]

I would start with just imitating the style, without rewriting any of the parsing code. That way, if we need to back out of trying to change the functions (like taking delete out of merge or separating create and adjust), we've already got a good looking update to offer.

Patrick Cuba Walter J. Ong S.J. Center for Digital Humanities Saint Louis University 314-977-4249

On Wed, Apr 19, 2017 at 3:59 PM, Bryan Haberberger <notifications@github.com

wrote:

Newberry Design:

[image: nd] https://urldefense.proofpoint.com/v2/url?u=https-3A__cloud.githubusercontent.com_assets_3287006_25201929_211dbd14-2D2519-2D11e7-2D81d6-2D1fa32ef11ae6.png&d=DwMFaQ&c=Pk_HpaIpE_jAoEC9PLIWoQ&r=Ob88fw3QcoIhBawyjgurXw&m=kFyHAIwdFoMX5WdpiC_8xg84H2MyAOoExLP6MpAIqz8&s=CjHbVONKkFGsoJUMw94Ro-3bZgiFY4fYFzd3Ut03tys&e=

T-PEN Design:

[image: td] https://urldefense.proofpoint.com/v2/url?u=https-3A__cloud.githubusercontent.com_assets_3287006_25201941_2a5ef35c-2D2519-2D11e7-2D8dc1-2Da0dec18d51d9.png&d=DwMFaQ&c=Pk_HpaIpE_jAoEC9PLIWoQ&r=Ob88fw3QcoIhBawyjgurXw&m=kFyHAIwdFoMX5WdpiC_8xg84H2MyAOoExLP6MpAIqz8&s=G_cmr0dSI6nfHw1UzcWhBQ3qFOy2vUc9SseuM28LK5w&e=

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_CenterForDigitalHumanities_TPEN-2DNewberry-2DItalian_issues_22-23issuecomment-2D295440028&d=DwMFaQ&c=Pk_HpaIpE_jAoEC9PLIWoQ&r=Ob88fw3QcoIhBawyjgurXw&m=kFyHAIwdFoMX5WdpiC_8xg84H2MyAOoExLP6MpAIqz8&s=SoSUD6n_py6XqNyd45-hsGF6Yd44Nm9VYLZJe-h1Umw&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABETvQ-2DYlBAq6WFSjzD7oxMIRFl58PtWks5rxnW8gaJpZM4NA13Z&d=DwMFaQ&c=Pk_HpaIpE_jAoEC9PLIWoQ&r=Ob88fw3QcoIhBawyjgurXw&m=kFyHAIwdFoMX5WdpiC_8xg84H2MyAOoExLP6MpAIqz8&s=FkqVut4LN_JSpijmp5dWYtU2hqNgAXOgUiNP3oAnZjc&e= .

[thehabes]

Yes, but to implement the design fully I have to change the parsing code because merge line and delete line are separated in TPEN but not Newberry, which cascades a little bit into other functions (like applyRuler()). However, if we decide we don't want to get into that, then we just get rid of "remove last line" from the design and I should be able to implement the design and the only change in the parsing code will be to connect the icons to the buttons, nothing in the logic. Perhaps we don't even want to change the design, and we just want to do the user friendly UX upgrades we did for it (#21) . Then, we don't have to alter any parsing code at all, just some CSS and cursor classing. It is still a bit up in the air how deep we wanted to go with this. This Epic is for that conversation.

[Domhnall101]

Bryan and Patrick are right ,all we want to do is the UX changes the merge and delete last line can stay together as a button. There will only every be a few users using this so If we end up with time for anything at the end it wont be this. Once Bryan has done that any work on this section will be bug fixing only I'll do digital comp for styling reference

[Domhnall101]

use the same size of button, text and icons as in tpen 28