search

CenterForDigitalHumanities / TinyNode

TinyThings in NodeJS
0 stars 1 forks source link

un-got #45

Closed cubap closed 5 months ago

cubap commented 6 months ago

mostly changed json to body in the requests and added the method option where needed.

cubap commented 6 months ago

I am unable to /create on localhost on the 44-refactor-got-for-fetch branch. I am using a fresh copy of the .env for tiny-node from dev.

image

Confirmed I do not experience this behavior when I use the main branch.

image

Can you confirm this works on https://tinydev.rerum.io right now /create? The error is nonsense, so far as I see. fetchResponse.json() is a thing. I'll switch in and confirm. I can move it inside of a then, if needed, but it is valid and works locally for me and on dev (which I think has the deploy from the PR)

cubap commented 6 months ago

Okay, @thehabes I have changed the await to explicitly pass the response into the .json() function in case its just a my machine vs. yours issue. It now looks like the changes that @jsvoo made in his refactor. All checks passing, still looking good on tinydev

cubap commented 5 months ago

I see the problem. It's outside of my code, but I can fix it. I'm not certain what version is working right now...

cubap commented 5 months ago

https://devstore.rerum.io/v1/id/66228fd85cc3848690279e96

cubap commented 5 months ago

image