search

CenterForOpenScience / SHARE

SHARE is building a free, open, data set about research and scholarly activities across their life cycle.
http://share-research.readthedocs.io/en/latest/index.html
Apache License 2.0
100 stars 58 forks source link

[SHARE-1049] Fix NIH harvester and department mapping #751

Closed aaxelb closed 6 years ago

aaxelb commented 6 years ago

Change the NIH transformer to save ORG_DEPT as a tag, not as a "Department" agent in SHARE. ORG_DEPT comes from a controlled vocabulary, and doesn't necessarily correspond to an actual department (e.g. "MISCELLANEOUS", "OTHER HEALTH PROFESSIONS", "OTHER BASIC SCIENCES")

While testing this, I discovered NIH changed the date format on their website, so the harvester hasn't run successfully in some time. This PR also fixes that, and will raise a more understandable error should they change their date format again.

https://openscience.atlassian.net/browse/SHARE-1049

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.0006%) to 78.839% when pulling f2ddd2188c061f3a3f32645587b78db8451c37df on aaxelb:share-1049--nih-departments into f5a8c3521fb51566cabc34166bb2a78792033cd7 on CenterForOpenScience:develop.