Open guscardvs opened 2 years ago
Hey @guscardvs!
Thanks for submitting this. This looks like the direction we want to move for aiohttpretty and a quick skim seems okay, but I'll need to spend some time carefully reviewing it. The apps we maintain that use this are still stuck on Python v3.6+, so I'll need to do some testing before we can adopt it.
In the meantime, I have a few questions:
aiohttpretty
? I'd be interested in knowing what new functionality is being used. I'd also like to know what other apps/libraries to test before releasing a new version.poetry
? I don't know much about current best practices, I'm just curious..cz.toml
? I'm not familiar with that tool.I also have some code nitpicks:
^M
s to the end of the lines. Could you remove those?develop
version (pinned, but never released to pypi) was set to 19.0.0
. Instead of bumping to 1.0.0
, could you bump to 22.0.0
? Our org has moved to CalVer for versioning releases.o
was removed from the maintainer email hereThank you, and have a great day! @felliott
Hi @felliott,
Let's one question at a time, 😄.
mock.patch
. The features I missed mostly, which lead me here, were pytest plugin, a simple context manager and decorator, instead of the manual activate
/deactivate
poetry
mostly because it's more performant than pdm and Pipenv as a package manager and it has builtin build and publish features, which reduces the need for twine or any other package management or pypi build/upload tool..cz.toml
is the config file for CommitizenAbout the code nitpicks, i will have them solved right now :).
Best regards, @guscardvs
Hi, here are some proposed changes to the project. Changes: