CenterForOpenScience / aiohttpretty

A simple asyncio compatible httpretty mock using aiohttp
12 stars 11 forks source link

Feature/refactor tests plugins #13

Open guscardvs opened 2 years ago

guscardvs commented 2 years ago

Hi, here are some proposed changes to the project. Changes:

felliott commented 2 years ago

Hey @guscardvs!

Thanks for submitting this. This looks like the direction we want to move for aiohttpretty and a quick skim seems okay, but I'll need to spend some time carefully reviewing it. The apps we maintain that use this are still stuck on Python v3.6+, so I'll need to do some testing before we can adopt it.

In the meantime, I have a few questions:

I also have some code nitpicks:

Thank you, and have a great day! @felliott

guscardvs commented 2 years ago

Hi @felliott,

Let's one question at a time, 😄.

About the code nitpicks, i will have them solved right now :).

Best regards, @guscardvs