[PLAT-494] Optimize Cos.io

CenterForOpenScience / cos.io

https://www.cos.io

Apache License 2.0

28 stars 74 forks source link

[PLAT-494] Optimize Cos.io #922

Closed Johnetordoff closed 6 years ago

Johnetordoff commented 6 years ago

Purpose

Cos.io currently runs cos.i-slow this fix addresses some of the things slowing it down.

Changes

Uses smaller image instead of massive 4000x2000 image on menu page
Prefetch photos takes queries from about 150 to about 100

Side Effects

None that I know of.

Ticket

https://openscience.atlassian.net/browse/PLAT-494

erinspace commented 6 years ago

You might consider trying to use django debug toolbar or n plus one while in dev mode like we do osfside as a part of this PR -- while you probably won't fix every problem these tools reveal, it'll at least give us a really good baseline for how to improve in the future. An attempt at that plus addressing steve's drivebys will be good for another CR pass!

erinspace commented 6 years ago

Just a question! Did you try checking out the debug toolbar to find more pages/queries to be optimized? How about nplusone? If you find ones that would take a significant amount of time to fix, you can create more specific tickets to fix them later, but I believe those should still be documented under the scope of this ticket.

Johnetordoff commented 6 years ago

@erinspace I did use the toolbar to find duplicate queries. It's pretty difficult to actually address these because most of the queries are for wagtail assets and not typical stuff, and even when I identify the assets which are causing duplicated queries I can't do much because they are baked into wagtail.

This is a pretty broad ticket and I wish I had more experience with optimization so I could know for sure, but I think it's just the number of assets on the page and the way wagtail is loading them that are responsible for the slowness.