[ENG-6436] Add new canBeRoot and mayContainRootCandidates flags - Githubissues

CenterForOpenScience / ember-osf-web

Ember front-end for the Open Science Framework

https://osf.io

Apache License 2.0

120 stars 56 forks source link

[ENG-6436] Add new canBeRoot and mayContainRootCandidates flags #2376

Closed futa-ikeda closed 2 weeks ago

futa-ikeda commented 2 weeks ago

Ticket: ENG-6436
Feature flag: n/a

Purpose

Add logic to prevent users from selecting or navigating into an inappropriate item when selecting a root folder

Summary of Changes

Add canBeRoot and mayContainRootCandidates flags to addon-operation-invocation item-results
Use these flags to control whether a user can navigate into that item (mayContainRootCandidates), or select an item as a root folder (canBeRoot)
Relevant GV PR https://github.com/CenterForOpenScience/gravyvalet/pull/139

Screenshot(s)

An example of items that can be roots or may contain roots for illustrative purposes. In practice, folders should be selectable as root folders and navigable to find root folder candidates
- FOLDER1: canBeRoot: true and mayContainRootCandidates: true
- FOLDER2: canBeRoot: false and mayContainRootCandidates: true
- FOLDER3: canBeRoot: true and mayContainRootCandidates: false

Side Effects

QA Notes