[ENG-6345] Prevent users from using unauthorized accounts to make a configured-addon - Githubissues

CenterForOpenScience / ember-osf-web

Ember front-end for the Open Science Framework

https://osf.io

Apache License 2.0

120 stars 56 forks source link

[ENG-6345] Prevent users from using unauthorized accounts to make a configured-addon #2380

Closed futa-ikeda closed 1 week ago

futa-ikeda commented 1 week ago

Ticket: ENG-6345
Feature flag: n/a

Purpose

Prevent users from creating a new unauthorized account and then selecting it later as an "Existing account"
Send users to the "Connect acccount" page if a user selects an unauthorized account
- Fix issues addon-account-setup component's reconnect workflow
Follow-up to this prior PR https://github.com/CenterForOpenScience/ember-osf-web/pull/2372

Summary of Changes

Delete newly created account if the auth workflow hasn't succeeded and the user cancels out of the account creation process
- Will not delete account if it is a "Reconnect"/Reauthorize workflow (checks if account is passed into addon-account-setup component
Miscellaneous whitespace changes

Screenshot(s)

Side Effects

QA Notes

futa-ikeda commented 1 week ago

Yea, this page is not the most pleasant to work through. Would like to do a clean up on it, now that there's some vestigial complexity that could be simplified now that we aren't allowing multiple accounts for a provider, but am a bit worried about how robust this page is... May have to settle for some helpful comments peppered in