AddisonSchiller
commented
7 years ago @felliott Random comments/CRR
Take a look at the settings questions, not quite sure how you want me to handle that.
On libtiff: I took a look at it, and it was sort of inconclusive. All i could find is there seem to be some tiff files that label things not to the tiff standard. using libtiff might help with those? I don't think we are using it in our docker container atm (it might come auto installed though.)
I did try to install it and see if it changed the way any of my test tiff files rendered and it did not seem to.
Just couldn't find enough information about it. Some of the docs linked to other libraries i originally looked at for rendering tiffs etc, and such. If you want i could definitely spend more time on this.
Also, leaving in additional development while I wait for responses to some of my questions
coveralls
felliott
adding more to pdf renderer tiff files are now rendered by the pdf renderer, and the pdf extension now has an exporter to handle tif/tiff files. Tiff files are now converted to pdfs for viewing
refs: https://openscience.atlassian.net/browse/SVCS-52
Purpose
Add support for mutlipage tiff files.
Summary of changes
Tiff files are sort of like pdfs, and can be converted to them. The pdf extension now handles tiff files. The pdf extension now has an exporter for tiff files Reportlab has been added as a dependency. Some multipage tiffs will not render correctly. see testing notes.
Testing QA notes:
below is a copy and paste of my testing notes on the jira ticket. you can find the zip file over there
Testing Notes:
Attached to the jira ticket is a zip containing some tif/tiff files to use for testing.
Due to the aspects of what this commit is doing, the following should also be tested: Other pdf files. Try a few regular pdf files and make sure they render properly. Any files rendered by the unoconv renderer. (ie docx) The unoconv renderer ships files to the pdf renderer.