[SVCS-287] Make iFrame scrollable for IE11

CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe

http://modular-file-renderer.readthedocs.io/en/latest/

Apache License 2.0

44 stars 67 forks source link

[SVCS-287] Make iFrame scrollable for IE11 #295

Closed Johnetordoff closed 7 years ago

Johnetordoff commented 7 years ago

Ticket

https://openscience.atlassian.net/browse/SVCS-287

Purpose

To make the Iframe scrollable on IE 11

Changes

Adds more js attributes for Iframe.

Side effects

None that I know of.

QA Notes

Only for IE11

Deployment Notes

Nothing special.

cslzchen commented 7 years ago

I forgot to mention that the scroll bar is at the end of the iframe so users still need to scroll all the way down. This is more of a QA/Prod question.

felliott commented 7 years ago

I've fixed the failing test locally. Merged.

Johnetordoff commented 7 years ago

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉