search

CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe
http://modular-file-renderer.readthedocs.io/en/latest/
Apache License 2.0
44 stars 67 forks source link

[SVCS-140] Bump `setuptools` to 37.0.0 (latest) #301

Closed cslzchen closed 6 years ago

cslzchen commented 7 years ago

Ticket

MFR Ticket: https://openscience.atlassian.net/browse/SVCS-140 Replaces: https://github.com/CenterForOpenScience/modular-file-renderer/pull/248

WB Ticket: https://openscience.atlassian.net/browse/SVCS-139 WB PR: https://github.com/CenterForOpenScience/waterbutler/pull/302

Purpose

All credits go to @Johnetordoff 🎆 , I just rebased/squashed the commits and fixed conflicts.

Let MFR run later versions of setuptools (>= 31.0 setuptools). Currently, the latest version is 37.0.0.

Changes

Creates version.py file where __version__ is defined to prevent circular import.

Side Effects

How can other applications, say Waterbutler, refer to this version? Please see my comment in the code: https://github.com/CenterForOpenScience/modular-file-renderer/pull/301#pullrequestreview-78262750

QA Notes

No

Developer Notes

After testing this PR, you need to downgrade your setuptools to work with current develop based branch. (Use your own virtualenv directory instead)

pip uninstall -y setuptools
rm -f ~/.virtualenv/mfr/lib/python3.5/site-packages/mfr-nspkg.pth
pip install setuptools==30.4.0

Deployment Notes

Please review to see if this affects you.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.02%) to 67.998% when pulling 50e63032b7ae95d6168128ba56ab8af09e60df04 on cslzchen:feature/fix-setup-tools into 8bb2dd4d35f8c1d89a72fc8b9e09db317f3497f3 on CenterForOpenScience:develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.02%) to 67.998% when pulling 85cee26892f83240dc772b00f8a2fc3ef6c0dac5 on cslzchen:feature/fix-setup-tools into 8bb2dd4d35f8c1d89a72fc8b9e09db317f3497f3 on CenterForOpenScience:develop.