[SVCS-674][PLAT-218] Relay MFR header requests to WB

CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe

http://modular-file-renderer.readthedocs.io/en/latest/

Apache License 2.0

44 stars 67 forks source link

[SVCS-674][PLAT-218] Relay MFR header requests to WB #321

Closed Johnetordoff closed 6 years ago

Johnetordoff commented 6 years ago

Ticket

SVCS-674 https://openscience.atlassian.net/browse/PLAT-709

Purpose

Currently the MFR doesn't pass any useful information about the render back to the osf. This fix in conjunction with https://github.com/CenterForOpenScience/waterbutler/pull/324 will allow osf.io to receive information more information about how a file was received for analytics purposes.

Changes

Relays MFRs Request headers to WB.

Side effects

None that I know of.

coveralls commented 6 years ago

Coverage decreased (-0.04%) to 72.328% when pulling 081734c12139773bdfb82f0c4d91cee1df04a08a on Johnetordoff:send-back-useful-header-info into 7150e664f5ef6835062802877dfa16a2c25263d9 on CenterForOpenScience:develop.

NyanHelsing commented 6 years ago

This seems fine to me. Only thing to be aware of is that this happens - would it be worth putting in documentation that any requests to mfr forward all headers to the third parties where the file is hosted?

felliott commented 6 years ago

After an in-person discussion with @Johnetordoff, we've decided to close this PR and continue the work in a new one. Instead of relaying all the headers/request metadata, we'll relay the important ones (referrer and request url) in specially named headers.