[HotFix] [SVCS-677] Fix Unsupported Export Type

CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe

http://modular-file-renderer.readthedocs.io/en/latest/

Apache License 2.0

43 stars 67 forks source link

[HotFix] [SVCS-677] Fix Unsupported Export Type #328

Closed cslzchen closed 6 years ago

cslzchen commented 6 years ago

Ticket

SVCS-677

Purpose

Fixed the bug where unsupported export types throw 400 assertion error instead of 400 exporter error. Remove the misleading comment which wrongly claims that get_exporter_name() is always called with a supported exporter. Update tests accordingly.

Changes

Before

before

After

after

Side effects

QA Notes

TBD

Deployment Notes

coveralls commented 6 years ago

Coverage decreased (-0.2%) to 71.254% when pulling ebc764ed7352f4b1ef312517ad708223718803f4 on cslzchen:bug-fix/unsupported-exporter into 68ede65f8c461abd1e64a08faf8e62abe552b1a7 on CenterForOpenScience:master.

cslzchen commented 6 years ago

@felliott I updated both cases for render.py and exporter.py. Ready for CR again.