search

CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe
http://modular-file-renderer.readthedocs.io/en/latest/
Apache License 2.0
43 stars 67 forks source link

[No Ticket] Add get_object to interpret JSON settings #336

Closed icereval closed 6 years ago

icereval commented 6 years ago

Ticket

N/A

Purpose

Allow JSON objects and arrays to be passed into as environment variable settings, needed for Storage Internationalization project.

Changes

Adds get_object to the base Settings class, in the correct alphabetical order.

Side effects

None

QA Notes

N/A

Deployment Notes

Can now use JSON in environment variables, e.g.

export SERVER_CONFIG_CACHE_PROVIDER_SETTINGS='{
  "bucket": "cos-osf-stage-files-ca-1-mfr"
}'
coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.02%) to 71.29% when pulling 0eac9632b5d2eea50fe59bb0445330772fedcee6 on icereval:feature/settings-get-object into f4a5cd22a319de430f84a02c6b77562c4246c5a8 on CenterForOpenScience:develop.