[SVCS-592] Fix idiotic bug

CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe

http://modular-file-renderer.readthedocs.io/en/latest/

Apache License 2.0

44 stars 67 forks source link

[SVCS-592] Fix idiotic bug #340

Closed NyanHelsing closed 6 years ago

NyanHelsing commented 6 years ago

Make the way image dimensions are pulled out of paths more robust

Ticket

https://openscience.atlassian.net/browse/SVCS-592

Purpose

Make an idiotic bug not happen. Changes the way that image sizes are pulled out of the url.

Changes

Side effects

QA Notes

Deployment Notes

coveralls commented 6 years ago

Coverage increased (+0.007%) to 71.218% when pulling f6709a94a63dfeddf75f48f174ee0604e8c471b3 on birdbrained:ft/fix-idiotic-bug into 62e0cde8ddc118c9d524b6cb783076a5ae33fc1f on CenterForOpenScience:develop.

cslzchen commented 6 years ago

I merged #339 to local develop, rebased #340 on the local develop and pushed back to the PR in order to have the same commit without pushing local develop up twice. A side effect is the PR's commit history looks bad. Next time I will merge them without rebasing on each other. cc @felliott

The develop looks good:

merge-mfr-339-340