search

CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe
http://modular-file-renderer.readthedocs.io/en/latest/
Apache License 2.0
43 stars 67 forks source link

[SVCS-828] Fix case-sensitive check for TIFF in PDF renderer #342

Closed cslzchen closed 6 years ago

cslzchen commented 6 years ago

Ticket

No Ticket

The issue was discovered during CR and testing https://github.com/CenterForOpenScience/modular-file-renderer/pull/330

Purpose

TIF/TIFF is both rendered and exported by the PDF renderer and exporter. However, the renderer only allows .tif and .tiff to be exported but accidentally leaves .TIF and .TIFF behind. They end up being rendered directly as PDF which fails.

tif-error

Changes

self.metadata.ext.l -->> self.metadata.ext.lower()

Side effects

No

QA Notes

Both https://staging.osf.io/9ra6c/ and https://staging.osf.io/vprtu/ works on staging.

Deployment Notes

No

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 70.932% when pulling 398cacda0209459217271d025115776864fd2d6a on cslzchen:fix/pdf-renderer-ext-case into 7885406c7fc36307e800ce0579075a59be5119e7 on CenterForOpenScience:develop.