CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe
http://modular-file-renderer.readthedocs.io/en/latest/
Apache License 2.0
43 stars 67 forks source link

Ft/docx rendering, RE: #304 #347

Open NyanHelsing opened 6 years ago

NyanHelsing commented 6 years ago

This is an update to https://github.com/CenterForOpenScience/modular-file-renderer/pull/304

Ticket

https://openscience.atlassian.net/browse/SVCS-488 OSF side PR: https://github.com/CenterForOpenScience/osf.io/pull/8002

Purpose

This ticket replaces https://github.com/CenterForOpenScience/modular-file-renderer/pull/282. Credit goes to @AddisonSchiller šŸŽ†šŸŽ†.

.docx rendering is very intensive on the OSF. By using Microsoft's online rendering service to render publicly available .docx files, we can remove a lot of pressure from the unoconv container.

Changes

Side Effects

QA Notes

The Office365 renderer does not use the.pdf renderer like unoconv used to, so the pdfs that get made by this renderer may not display exactly the same. More QA notes to come. There is also a README.md in the renderer with more information about testing.

Deployment Notes

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 71.042% when pulling edc9c184c1fc2db2adfaf186d4915589ecfc5211 on birdbrained:ft/docx-rendering into d15d3224c522958d63ea8470c55879e53fa2176f on CenterForOpenScience:develop.